Ticket #535 (new defect)

Opened 17 months ago

Last modified 16 months ago

The error controller document() action crashes when called directly

Reported by: thejimmyg Owned by: pjenvey
Priority: normal Milestone:
Component: controllers Version: 0.9.7
Severity: normal Keywords:
Cc:

Description

To make it more resilient it should look like the attachment.

This code can now be called directly. It also uses an empty message if none is specified and raises an Exception if no code is specified - but these weren't features of the original.

If you aren't planning another release candidate, this should probably wait until 0.9.7.1

Attachments

new_document_action.txt Download (0.7 KB) - added by thejimmyg 17 months ago.

Change History

Changed 17 months ago by thejimmyg

Changed 17 months ago by thejimmyg

Also, a bigger problem is that the message now seems to contain HTML. This is a bad idea because it means that if you are using a custom error template like the one in the book you find that a title has already been added for you to the message and you have to strip it out (or work around it). It also explains the use of literal() in the current implementation. I think this should be removed along with the use of literal.

Changed 16 months ago by pjenvey

Why isn't this a patch James? That would make it easier to read

Note: See TracTickets for help on using tickets.


Powered by Pylons - Contact Administrators